From: n0tlu5 <darfisultoni@gmail.com>
Date: Fri, 24 May 2024 06:35:04 +0000 (+0700)
Subject: reduce exception handling
X-Git-Tag: dnsdist-2.0.0-alpha1~178^2~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1676c6d3f36826da5126a8ca2ef2ab78b2265ed1;p=thirdparty%2Fpdns.git

reduce exception handling
---

diff --git a/pdns/lua-record.cc b/pdns/lua-record.cc
index cf95e0ea35..0a0f5dbad0 100644
--- a/pdns/lua-record.cc
+++ b/pdns/lua-record.cc
@@ -128,8 +128,9 @@ private:
         throw std::runtime_error(boost::str(boost::format("unable to match content with `%s`") % cd.opts.at("stringmatch")));
       }
 
+      int weight = 0;
       try {
-        stoi(content);
+        weight = stoi(content);
         if(!status) {
           g_log<<Logger::Info<<"LUA record monitoring declaring "<<remstring<<" UP for URL "<<cd.url<<"!"<<" with WEIGHT "<<content<<"!"<<endl;
         }
@@ -140,7 +141,7 @@ private:
         }
       }
 
-      setWeight(cd, content);
+      setWeight(cd, weight);
       setUp(cd);
     }
     catch(std::exception& ne) {
@@ -232,15 +233,10 @@ private:
     }
   }
   
-  void setWeight(const CheckDesc& cd, string content){
+  void setWeight(const CheckDesc& cd, int weight){
     auto statuses = d_statuses.write_lock();
     auto& state = (*statuses)[cd];
-    try {
-      state->weight = stoi(content);
-    } catch (const PDNSException& e) {
-      // set weight to 0
-      state->weight = 0;
-    }
+    state->weight = weight;
     if (state->first) {
       state->first = false;
     }