From: Robin Geuze <robing@transip.nl>
Date: Wed, 17 Feb 2021 13:10:04 +0000 (+0100)
Subject: Check in both commitTransaction and abortTransaction whether a transaction is actuall... 
X-Git-Tag: rec-4.5.0-beta1~10^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=169c71c8338554a2499bb9bb983e1ee248209667;p=thirdparty%2Fpdns.git

Check in both commitTransaction and abortTransaction whether a transaction is actually active
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 158429460f..c2fa92deb1 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -364,6 +364,10 @@ bool LMDBBackend::startTransaction(const DNSName &domain, int domain_id)
 bool LMDBBackend::commitTransaction()
 {
   // cout<<"Commit transaction" <<endl;
+  if (!d_rwtxn) {
+    throw DBException("Attempt to commit a transaction while there isn't one open");
+  }
+
   d_rwtxn->txn->commit();
   d_rwtxn.reset();
   return true;
@@ -372,6 +376,10 @@ bool LMDBBackend::commitTransaction()
 bool LMDBBackend::abortTransaction()
 {
   // cout<<"Abort transaction"<<endl;
+  if (!d_rwtxn) {
+      throw DBException("Attempt to abort a transaction while there isn't one open");
+  }
+
   d_rwtxn->txn->abort();
   d_rwtxn.reset();