From: Victor Julien <vjulien@oisf.net>
Date: Fri, 21 Apr 2023 08:25:30 +0000 (+0200)
Subject: suricata: work around scan-build warnings
X-Git-Tag: suricata-6.0.12~50
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=16cadd7e59e6742182b53ee02cb0e219c0d637fc;p=thirdparty%2Fsuricata.git

suricata: work around scan-build warnings

suricata.c:691:17: warning: Value stored to 'bits' during its initialization is never read [deadcode.DeadStores]
    const char *bits = "<unknown>-bits";
                ^~~~   ~~~~~~~~~~~~~~~~
suricata.c:692:17: warning: Value stored to 'endian' during its initialization is never read [deadcode.DeadStores]
    const char *endian = "<unknown>-endian";
                ^~~~~~   ~~~~~~~~~~~~~~~~~~
2 warnings generated.

(cherry picked from commit c13a6fa73c4c42826d12d9630878c8000d7a6dd4)
---

diff --git a/src/suricata.c b/src/suricata.c
index ba1bf753ec..0f7bb5ccb2 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -698,8 +698,8 @@ static void PrintUsage(const char *progname)
 
 static void PrintBuildInfo(void)
 {
-    const char *bits = "<unknown>-bits";
-    const char *endian = "<unknown>-endian";
+    const char *bits;
+    const char *endian;
     char features[2048] = "";
     const char *tls;
 
@@ -831,12 +831,16 @@ static void PrintBuildInfo(void)
     bits = "64-bits";
 #elif __WORDSIZE == 32
     bits = "32-bits";
+#else
+    bits = "<unknown>-bits";
 #endif
 
 #if __BYTE_ORDER == __BIG_ENDIAN
     endian = "Big-endian";
 #elif __BYTE_ORDER == __LITTLE_ENDIAN
     endian = "Little-endian";
+#else
+    endian = "<unknown>-endian";
 #endif
 
     printf("%s, %s architecture\n", bits, endian);