From: Masud Hasan (mashasan) <mashasan@cisco.com>
Date: Tue, 14 Jun 2022 13:31:09 +0000 (+0000)
Subject: Pull request #3460: openssl: Openssl minimum version is set to 1.1.1
X-Git-Tag: 3.1.32.0~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=16f703d63c6ecc24e05b3699ec7b2ec6f334ffb3;p=thirdparty%2Fsnort3.git

Pull request #3460: openssl: Openssl minimum version is set to 1.1.1

Merge in SNORT/snort3 from ~OSTEPANO/snort3:openssl_version_check to master

Squashed commit of the following:

commit 08d6c9f9168f357f3c245c110864dc253fdb9b18
Author: ostepano <ostepano@cisco.com>
Date:   Mon Jun 6 09:14:36 2022 -0400

    openssl: Openssl minimum version is set to 1.1.1
---

diff --git a/cmake/include_libraries.cmake b/cmake/include_libraries.cmake
index 783704eba..b3b4fd457 100644
--- a/cmake/include_libraries.cmake
+++ b/cmake/include_libraries.cmake
@@ -6,7 +6,7 @@ find_package(DNET REQUIRED)
 find_package(FlexLexer REQUIRED)
 find_package(HWLOC REQUIRED)
 find_package(LuaJIT REQUIRED)
-find_package(OpenSSL REQUIRED)
+find_package(OpenSSL 1.1.1 REQUIRED)
 find_package(PCAP REQUIRED)
 find_package(PCRE REQUIRED)
 find_package(ZLIB REQUIRED)
diff --git a/src/network_inspectors/appid/appid_inspector.cc b/src/network_inspectors/appid/appid_inspector.cc
index 34d01362b..7cc690415 100644
--- a/src/network_inspectors/appid/appid_inspector.cc
+++ b/src/network_inspectors/appid/appid_inspector.cc
@@ -64,13 +64,6 @@ THREAD_LOCAL OdpContext* pkt_thread_odp_ctxt = nullptr;
 
 static THREAD_LOCAL PacketTracer::TracerMute appid_mute;
 
-// FIXIT-L - appid cleans up openssl now as it is the primary (only) user... eventually this
-//           should probably be done outside of appid
-static void openssl_cleanup()
-{
-    CRYPTO_cleanup_all_ex_data();
-}
-
 static void add_appid_to_packet_trace(Flow& flow, const OdpContext& odp_context)
 {
     AppIdSession* session = appid_api.get_appid_session(flow);
@@ -237,7 +230,6 @@ static void appid_inspector_pinit()
 static void appid_inspector_pterm()
 {
     AppIdContext::pterm();
-    openssl_cleanup();
     TPLibHandler::pfini();
 }
 
diff --git a/src/utils/util.cc b/src/utils/util.cc
index 298c747c4..6b800e940 100644
--- a/src/utils/util.cc
+++ b/src/utils/util.cc
@@ -107,7 +107,7 @@ int DisplayBanner()
     LogMessage("           Copyright (C) 1998-2013 Sourcefire, Inc., et al.\n");
     LogMessage("           Using DAQ version %s\n", daq_version_string());
     LogMessage("           Using LuaJIT version %s\n", ljv);
-    LogMessage("           Using %s\n", SSLeay_version(SSLEAY_VERSION));
+    LogMessage("           Using %s\n", OpenSSL_version(SSLEAY_VERSION));
     LogMessage("           Using %s\n", pcap_lib_version());
     LogMessage("           Using PCRE version %s\n", pcre_version());
     LogMessage("           Using ZLIB version %s\n", zlib_version);