From: Michael Paquier Date: Mon, 15 Dec 2025 01:28:28 +0000 (+0900) Subject: pageinspect: use index_close() for GiST index relation X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=171198ff2a57fafe0772ec9d3dfbf061cffffacd;p=thirdparty%2Fpostgresql.git pageinspect: use index_close() for GiST index relation gist_page_items() opens its target relation with index_open(), but closed it using relation_close() instead of index_close(). This was harmless because index_close() and relation_close() do the exact same work, still inconsistent with the rest of the code tree as routines opening and closing a relation based on a relkind are expected to match, at least in name. Author: Chao Li Discussion: https://postgr.es/m/CAEoWx2=bL41WWcD-4Fxx-buS2Y2G5=9PjkxZbHeFMR6Uy2WNvw@mail.gmail.com --- diff --git a/contrib/pageinspect/gistfuncs.c b/contrib/pageinspect/gistfuncs.c index de3746a156b..414513c395b 100644 --- a/contrib/pageinspect/gistfuncs.c +++ b/contrib/pageinspect/gistfuncs.c @@ -361,7 +361,7 @@ gist_page_items(PG_FUNCTION_ARGS) tuplestore_putvalues(rsinfo->setResult, rsinfo->setDesc, values, nulls); } - relation_close(indexRel, AccessShareLock); + index_close(indexRel, AccessShareLock); return (Datum) 0; }