From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Tue, 16 Aug 2022 08:26:35 +0000 (+0100)
Subject: Remove a few causes of "possibly uninitialised" warnings.
X-Git-Tag: 4.1-rc1~24^2~26^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=174556f05486393a9f2b4ef80e144f5b9b545dc3;p=thirdparty%2Fshairport-sync.git

Remove a few causes of "possibly uninitialised" warnings.
---

diff --git a/player.c b/player.c
index 5f124680..15ee9671 100644
--- a/player.c
+++ b/player.c
@@ -1746,8 +1746,8 @@ void *player_thread_func(void *arg) {
   rtsp_conn_info *conn = (rtsp_conn_info *)arg;
 
   uint64_t previous_frames_played;
-  uint64_t previous_raw_measurement_time;
-  uint64_t previous_corrected_measurement_time;
+  uint64_t previous_raw_measurement_time = 0; // initialised to avoid a "possibly uninitialised" warning
+  uint64_t previous_corrected_measurement_time = 0; // initialised to avoid a "possibly uninitialised" warning
   int previous_frames_played_valid = 0;
 
   // pthread_cleanup_push(player_thread_initial_cleanup_handler, arg);
diff --git a/rtp.c b/rtp.c
index 844f55fe..247f1689 100644
--- a/rtp.c
+++ b/rtp.c
@@ -2362,7 +2362,7 @@ void *rtp_buffered_audio_processor(void *arg) {
   uint8_t *pcm_audio = NULL;  // the S16 output
   unsigned char *data_to_process;
   ssize_t data_remaining;
-  uint32_t seq_no; // audio packet number
+  uint32_t seq_no = 0; // audio packet number. Initialised to avoid a "possibly uninitialised" warning.
   // uint32_t previous_seq_no = 0;
   int new_buffer_needed = 0;
   ssize_t nread;
@@ -2380,10 +2380,10 @@ void *rtp_buffered_audio_processor(void *arg) {
   uint64_t blocks_read_since_flush = 0;
   int flush_requested = 0;
 
-  uint32_t timestamp;
+  uint32_t timestamp = 0; // initialised to avoid a "possibly uninitialised" warning.
   int streaming_has_started = 0;
   int play_enabled = 0;
-  uint32_t flush_from_timestamp;
+  uint32_t flush_from_timestamp = 0; // initialised to avoid a "possibly uninitialised" warning.
   double requested_lead_time = 0.0; // normal lead time minimum -- maybe  it should be about 0.1
 
   // wait until our timing information is valid