From: Otto <otto.moerbeek@open-xchange.com>
Date: Mon, 13 Sep 2021 11:38:52 +0000 (+0200)
Subject: Add comment: we do not do SNI (and the idle connections pooling does not work for... 
X-Git-Tag: rec-4.6.0-alpha1~2^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=176cbf390b0a471e348e97cb8ba7d64e365bbff4;p=thirdparty%2Fpdns.git

Add comment: we do not do SNI (and the idle connections pooling does not work for that case atm)
---

diff --git a/pdns/recursordist/rec-tcpout.hh b/pdns/recursordist/rec-tcpout.hh
index 2c07655ac3..91f67ae3a3 100644
--- a/pdns/recursordist/rec-tcpout.hh
+++ b/pdns/recursordist/rec-tcpout.hh
@@ -66,6 +66,8 @@ public:
   }
 
 private:
+  // This does not take into account that we can have multiple connections with different hosts (via SNI) to the same IP.
+  // That is OK, since we are connecting by IP only at the moment.
   std::multimap<ComboAddress, Connection> d_idle_connections;
 };