From: Volker Lendecke <vl@samba.org>
Date: Wed, 8 May 2024 14:05:40 +0000 (+0200)
Subject: libsmb: Use the direct FSCC_FILE_ALL_INFORMATION define
X-Git-Tag: tdb-1.4.11~696
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1776918c5bf2e6db4ab9072e09326b91fa211322;p=thirdparty%2Fsamba.git

libsmb: Use the direct FSCC_FILE_ALL_INFORMATION define

(SMB_FILE_ALL_INFORMATION - 1000) looks a bit silly if you look at the
definition of SMB_FILE_ALL_INFORMATION...

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/torture/test_smb2.c b/source3/torture/test_smb2.c
index 3b2e1e4811d..29d2b65f2a4 100644
--- a/source3/torture/test_smb2.c
+++ b/source3/torture/test_smb2.c
@@ -3951,20 +3951,21 @@ static NTSTATUS get_smb2_inode(struct cli_state *cli,
 	/*
 	 * Get the inode.
 	 */
-	status = smb2cli_query_info(cli->conn,
-				    cli->timeout,
-				    cli->smb2.session,
-				    cli->smb2.tcon,
-				    SMB2_0_INFO_FILE,
-				    (SMB_FILE_ALL_INFORMATION - 1000), /* in_file_info_class */
-				    1024, /* in_max_output_length */
-				    NULL, /* in_input_buffer */
-				    0, /* in_additional_info */
-				    0, /* in_flags */
-				    fid_persistent,
-				    fid_volatile,
-				    talloc_tos(),
-				    &outbuf);
+	status = smb2cli_query_info(
+		cli->conn,
+		cli->timeout,
+		cli->smb2.session,
+		cli->smb2.tcon,
+		SMB2_0_INFO_FILE,
+		FSCC_FILE_ALL_INFORMATION, /* in_file_info_class */
+		1024,			   /* in_max_output_length */
+		NULL,			   /* in_input_buffer */
+		0,			   /* in_additional_info */
+		0,			   /* in_flags */
+		fid_persistent,
+		fid_volatile,
+		talloc_tos(),
+		&outbuf);
 
 	if (NT_STATUS_IS_OK(status)) {
 		*ino_ret = PULL_LE_U64(outbuf.data, 0x40);