From: Benjamin Drung Date: Sat, 1 Nov 2025 10:49:33 +0000 (+0100) Subject: test: drop requiring iscsiuio.socket X-Git-Tag: 109~5 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=177b9913df0787db98979ec2aa5942473b0cae12;p=thirdparty%2Fdracut-ng.git test: drop requiring iscsiuio.socket The iscsiuio socket/service is only needed on specific hardware. It is not needed for the ISCSI and ISCSI-MULTI test cases. Without this check the tests will succeed on Debian and Ubuntu. Fixes: https://github.com/dracut-ng/dracut-ng/issues/446 --- diff --git a/.github/workflows/integration-extra.yml b/.github/workflows/integration-extra.yml index 594ec33fe..61eb00a8a 100644 --- a/.github/workflows/integration-extra.yml +++ b/.github/workflows/integration-extra.yml @@ -128,13 +128,6 @@ jobs: - "70" - "71" - "72" - exclude: - # https://github.com/dracut-ng/dracut-ng/issues/446 - - container: debian:sid - test: "70" - # https://github.com/dracut-ng/dracut-ng/issues/446 - - container: debian:sid - test: "71" container: image: ghcr.io/dracut-ng/${{ matrix.container }}-amd options: '--device=/dev/kvm' diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 240d1d29f..a88649b3f 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -198,11 +198,17 @@ jobs: matrix: container: - arch:latest + - debian:latest - opensuse:latest + - ubuntu:devel test: - "70" - "71" - "72" + exclude: + # https://github.com/dracut-ng/dracut-ng/issues/1815 + - container: ubuntu:devel + test: "72" container: image: ghcr.io/dracut-ng/${{ matrix.container }}-amd options: '--device=/dev/kvm' diff --git a/test/TEST-70-ISCSI/test.sh b/test/TEST-70-ISCSI/test.sh index 9bc58c0d6..0cfdfdeee 100755 --- a/test/TEST-70-ISCSI/test.sh +++ b/test/TEST-70-ISCSI/test.sh @@ -122,10 +122,6 @@ test_check() { echo "Need tgtd and tgtadm from scsi-target-utils" return 1 fi - if ! [ -f /lib/systemd/system/iscsiuio.socket ]; then - echo "Need iscsiuio.socket to run this test" - return 1 - fi } test_setup() { diff --git a/test/TEST-71-ISCSI-MULTI/test.sh b/test/TEST-71-ISCSI-MULTI/test.sh index 818a07095..9324cae44 100755 --- a/test/TEST-71-ISCSI-MULTI/test.sh +++ b/test/TEST-71-ISCSI-MULTI/test.sh @@ -129,10 +129,6 @@ test_check() { echo "Need tgtd and tgtadm from scsi-target-utils" return 1 fi - if ! [ -f /lib/systemd/system/iscsiuio.socket ]; then - echo "Need iscsiuio.socket to run this test" - return 1 - fi } test_setup() {