From: Mark Andrews <marka@isc.org>
Date: Tue, 25 Feb 2025 03:54:55 +0000 (+1100)
Subject: Check if key is NULL before dereferencing it
X-Git-Tag: ondrej/lock-free-qpzone-reads-v1~26^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1784e4a9aebc83ef22018cc35eeeea12e7ae2a14;p=thirdparty%2Fbind9.git

Check if key is NULL before dereferencing it
---

diff --git a/bin/dnssec/dnssec-signzone.c b/bin/dnssec/dnssec-signzone.c
index 9101098470b..caf8f125d1d 100644
--- a/bin/dnssec/dnssec-signzone.c
+++ b/bin/dnssec/dnssec-signzone.c
@@ -552,7 +552,7 @@ signset(dns_diff_t *del, dns_diff_t *add, dns_dbnode_t *node, dns_name_t *name,
 		future = isc_serial_lt(now, rrsig.timesigned);
 
 		key = keythatsigned(&rrsig);
-		offline = key->pubkey;
+		offline = (key != NULL) ? key->pubkey : false;
 		sig_format(&rrsig, sigstr, sizeof(sigstr));
 		expired = isc_serial_gt(now, rrsig.timeexpire);
 		refresh = isc_serial_gt(now + cycle, rrsig.timeexpire);