From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 27 Jul 2015 15:14:03 +0000 (-0400)
Subject: redisConnect() may return NULL
X-Git-Tag: release_3_0_10~288
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=17ca130fc1c386b97213976fea74bf562d44481d;p=thirdparty%2Ffreeradius-server.git

redisConnect() may return NULL

It's possible.  Better check for it
---

diff --git a/src/modules/rlm_redis/rlm_redis.c b/src/modules/rlm_redis/rlm_redis.c
index 993884c8957..561e0f365d8 100644
--- a/src/modules/rlm_redis/rlm_redis.c
+++ b/src/modules/rlm_redis/rlm_redis.c
@@ -64,6 +64,12 @@ static void *mod_conn_create(TALLOC_CTX *ctx, void *instance)
 	char buffer[1024];
 
 	conn = redisConnect(inst->hostname, inst->port);
+	if (!conn) {
+		ERROR("rlm_redis (%s): Failed calling redisConnect('%s', %d)",
+		      inst->xlat_name, inst->hostname, inst->port);
+		return NULL;
+	}
+
 	if (conn && conn->err) {
 		ERROR("rlm_redis (%s): Problems with redisConnect('%s', %d), %s",
 				inst->xlat_name, inst->hostname, inst->port, redisReplyReaderGetError(conn));