From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Date: Sat, 11 May 2019 23:39:51 +0000 (+0200)
Subject: criu: Remove unnecessary return after _exit()
X-Git-Tag: lxc-3.2.0~54^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=17e68c49cf920fba52e937dcf6e0071035ee7927;p=thirdparty%2Flxc.git

criu: Remove unnecessary return after _exit()

Since _exit() will terminate, the return statement is dead code. Also,
returning -1 from a function with bool as return type is confusing.

Detected with cppcheck.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---

diff --git a/src/lxc/criu.c b/src/lxc/criu.c
index 1b74cf813..86f6f1836 100644
--- a/src/lxc/criu.c
+++ b/src/lxc/criu.c
@@ -1273,7 +1273,6 @@ static bool do_dump(struct lxc_container *c, char *mode, struct migrate_opts *op
 		if (!cgroup_ops) {
 			ERROR("failed to cgroup_init()");
 			_exit(EXIT_FAILURE);
-			return -1;
 		}
 
 		os.pipefd = criuout[1];