From: Volker Lendecke Date: Thu, 5 Jan 2023 14:17:14 +0000 (+0100) Subject: smbd: Fix CID 1518901 Logically dead code X-Git-Tag: talloc-2.4.0~66 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=17e9758b537e3a43f4f290debdc2b812abb394ed;p=thirdparty%2Fsamba.git smbd: Fix CID 1518901 Logically dead code Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme --- diff --git a/source3/smbd/smb1_trans2.c b/source3/smbd/smb1_trans2.c index 0a6156d45e0..ceb92575955 100644 --- a/source3/smbd/smb1_trans2.c +++ b/source3/smbd/smb1_trans2.c @@ -4409,7 +4409,6 @@ static void call_trans2setpathinfo( struct files_struct *fsp = NULL; char *params = *pparams; uint32_t ucf_flags = ucf_flags_from_smb_request(req); - bool require_existing_object = true; NTTIME twrp = 0; char *fname = NULL; bool info_level_handled; @@ -4567,30 +4566,6 @@ static void call_trans2setpathinfo( */ fsp = smb_fname->fsp; - /* - * There are 4 info levels which can - * create a new object in the filesystem. - * They are: - * SMB_SET_FILE_UNIX_LINK -> creates POSIX symlink. - * SMB_POSIX_PATH_OPEN -> creates POSIX file or directory. - * SMB_SET_FILE_UNIX_BASIC: - * SMB_SET_FILE_UNIX_INFO2: can create a POSIX special file. - * - * These info levels do not require an existing object. - */ - switch (info_level) { - case SMB_SET_FILE_UNIX_BASIC: - case SMB_SET_FILE_UNIX_INFO2: - require_existing_object = false; - break; - default: - break; - } - - if (!VALID_STAT(smb_fname->st) && require_existing_object) { - reply_nterror(req, NT_STATUS_OBJECT_NAME_NOT_FOUND); - } - status = smbd_do_setfilepathinfo( conn, req,