From: Daniel P. Berrangé <berrange@redhat.com>
Date: Fri, 22 Jan 2021 14:48:03 +0000 (+0000)
Subject: qemu: record deprecation messages against the domain
X-Git-Tag: v7.1.0-rc1~134
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=17f001c4512929eb68fa67fc1b3520a214c78fed;p=thirdparty%2Flibvirt.git

qemu: record deprecation messages against the domain

These messages are only valid while the domain is running.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 14d05cfe3b..223a082d18 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -6239,6 +6239,11 @@ void qemuDomainObjTaintMsg(virQEMUDriverPtr driver,
         va_end(args);
     }
 
+    if (taint == VIR_DOMAIN_TAINT_DEPRECATED_CONFIG &&
+        extramsg) {
+        virDomainObjDeprecation(obj, extramsg);
+    }
+
     VIR_WARN("Domain id=%d name='%s' uuid=%s is tainted: %s%s%s%s",
              obj->def->id,
              obj->def->name,
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index b95f7514ba..7feb35e609 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -7849,6 +7849,11 @@ void qemuProcessStop(virQEMUDriverPtr driver,
         }
     }
 
+    for (i = 0; i < vm->ndeprecations; i++)
+        g_free(vm->deprecations[i]);
+    g_free(vm->deprecations);
+    vm->ndeprecations = 0;
+    vm->deprecations = NULL;
     vm->taint = 0;
     vm->pid = -1;
     virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, reason);