From: lpsolit%gmail.com <>
Date: Tue, 7 Feb 2006 17:31:22 +0000 (+0000)
Subject: Bug 313806: Whine E-mails do not "Order" the Queries Correctly - Patch by Frédéric... 
X-Git-Tag: bugzilla-2.20.1~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=17f6866278a1bd9fe7c4bea63c2346a2bad29c0e;p=thirdparty%2Fbugzilla.git

Bug 313806: Whine E-mails do not "Order" the Queries Correctly - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
---

diff --git a/whine.pl b/whine.pl
index 96356f1fab..e584646f5b 100755
--- a/whine.pl
+++ b/whine.pl
@@ -51,7 +51,7 @@ my @seen_schedules = ();
 # allow the database to keep their SQL compiled.
 my $sth_run_queries =
     $dbh->prepare("SELECT " .
-                  "id, query_name, title, onemailperbug " .
+                  "query_name, title, onemailperbug " .
                   "FROM whine_queries " .
                   "WHERE eventid=? " .
                   "ORDER BY sortkey");
@@ -429,18 +429,19 @@ sub run_queries {
     my $return_queries = [];
 
     $sth_run_queries->execute($args->{'eventid'});
-    my $queries = {};
+    my @queries = ();
     for (@{$sth_run_queries->fetchall_arrayref}) {
-        $queries->{$_->[0]} = {
-            'name'          => $_->[1],
-            'title'         => $_->[2],
-            'onemailperbug' => $_->[3],
-            'bugs'          => [],
-        };
+        push(@queries,
+            {
+              'name'          => $_->[0],
+              'title'         => $_->[1],
+              'onemailperbug' => $_->[2],
+              'bugs'          => [],
+            }
+        );
     }
 
-    for my $query_id (keys %{$queries}) {
-        my $thisquery = $queries->{$query_id};
+    foreach my $thisquery (@queries) {
         next unless $thisquery->{'name'};   # named query is blank
 
         my $savedquery = get_query($thisquery->{'name'}, $args->{'author'});