From: Orgad Shaneh <orgad.shaneh@audiocodes.com>
Date: Wed, 15 May 2024 07:02:36 +0000 (+0300)
Subject: socket: remove redundant call to getsockname
X-Git-Tag: curl-8_8_0~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=17fbed20088a4f76985521f851e5a09c89f0d872;p=thirdparty%2Fcurl.git

socket: remove redundant call to getsockname

The result "add" is unused.

Closes #13655
---

diff --git a/lib/cf-socket.c b/lib/cf-socket.c
index 63826fbc1d..737f6298ba 100644
--- a/lib/cf-socket.c
+++ b/lib/cf-socket.c
@@ -616,16 +616,6 @@ static CURLcode bindlocal(struct Curl_easy *data, struct connectdata *conn,
   for(;;) {
     if(bind(sockfd, sock, sizeof_sa) >= 0) {
       /* we succeeded to bind */
-      struct Curl_sockaddr_storage add;
-      curl_socklen_t size = sizeof(add);
-      memset(&add, 0, sizeof(struct Curl_sockaddr_storage));
-      if(getsockname(sockfd, (struct sockaddr *) &add, &size) < 0) {
-        char buffer[STRERROR_LEN];
-        data->state.os_errno = error = SOCKERRNO;
-        failf(data, "getsockname() failed with errno %d: %s",
-              error, Curl_strerror(error, buffer, sizeof(buffer)));
-        return CURLE_INTERFACE_FAILED;
-      }
       infof(data, "Local port: %hu", port);
       conn->bits.bound = TRUE;
       return CURLE_OK;