From: Ben Darnell <ben@bendarnell.com>
Date: Thu, 11 Jul 2024 19:26:14 +0000 (-0400)
Subject: test: Remove some obsolete checks for old python versions
X-Git-Tag: v6.5.0b1~39^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1808129122f81b0e78120c29233381be5c37b0b8;p=thirdparty%2Ftornado.git

test: Remove some obsolete checks for old python versions
---

diff --git a/tornado/test/gen_test.py b/tornado/test/gen_test.py
index 1a365dbd..ec3a6c8e 100644
--- a/tornado/test/gen_test.py
+++ b/tornado/test/gen_test.py
@@ -572,9 +572,6 @@ class GenCoroutineTest(AsyncTestCase):
         self.finished = True
 
     @skipNotCPython
-    @unittest.skipIf(
-        (3,) < sys.version_info < (3, 6), "asyncio.Future has reference cycles"
-    )
     def test_coroutine_refcounting(self):
         # On CPython, tasks and their arguments should be released immediately
         # without waiting for garbage collection.
diff --git a/tornado/test/iostream_test.py b/tornado/test/iostream_test.py
index 200b0830..09191ecf 100644
--- a/tornado/test/iostream_test.py
+++ b/tornado/test/iostream_test.py
@@ -27,7 +27,6 @@ from tornado.testing import (
 from tornado.test.util import (
     skipIfNonUnix,
     refusing_port,
-    skipPypy3V58,
     ignore_deprecation,
     abstract_base_test,
 )
@@ -828,7 +827,6 @@ class TestIOStreamMixin(TestReadWriteMixin):
             client.close()
 
     @skipIfNonUnix
-    @skipPypy3V58
     @gen_test
     def test_inline_read_error(self):
         # An error on an inline read is raised without logging (on the
@@ -862,7 +860,6 @@ class TestIOStreamMixin(TestReadWriteMixin):
             server.close()
             client.close()
 
-    @skipPypy3V58
     @gen_test
     def test_async_read_error_logging(self):
         # Socket errors on asynchronous reads should be logged (but only
diff --git a/tornado/test/netutil_test.py b/tornado/test/netutil_test.py
index 23347278..117a9d7f 100644
--- a/tornado/test/netutil_test.py
+++ b/tornado/test/netutil_test.py
@@ -1,5 +1,4 @@
 import errno
-import os
 import signal
 import socket
 from subprocess import Popen
diff --git a/tornado/test/tcpclient_test.py b/tornado/test/tcpclient_test.py
index 73b383cb..5638559c 100644
--- a/tornado/test/tcpclient_test.py
+++ b/tornado/test/tcpclient_test.py
@@ -14,7 +14,6 @@
 # under the License.
 from contextlib import closing
 import getpass
-import os
 import socket
 import unittest
 
diff --git a/tornado/test/util.py b/tornado/test/util.py
index 2e8bc3e5..ed5fd5d3 100644
--- a/tornado/test/util.py
+++ b/tornado/test/util.py
@@ -24,16 +24,6 @@ skipNotCPython = unittest.skipIf(
     platform.python_implementation() != "CPython", "Not CPython implementation"
 )
 
-# Used for tests affected by
-# https://bitbucket.org/pypy/pypy/issues/2616/incomplete-error-handling-in
-# TODO: remove this after pypy3 5.8 is obsolete.
-skipPypy3V58 = unittest.skipIf(
-    platform.python_implementation() == "PyPy"
-    and sys.version_info > (3,)
-    and sys.pypy_version_info < (5, 9),  # type: ignore
-    "pypy3 5.8 has buggy ssl module",
-)
-
 
 def _detect_ipv6():
     if not socket.has_ipv6: