From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 21 Dec 2023 00:59:18 +0000 (-0500)
Subject: return on error or correct parse.  Ignore noop
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=182209360;p=thirdparty%2Ffreeradius-server.git

return on error or correct parse.  Ignore noop
---

diff --git a/src/lib/server/tmpl_tokenize.c b/src/lib/server/tmpl_tokenize.c
index 23d013fcc28..3f19ef44446 100644
--- a/src/lib/server/tmpl_tokenize.c
+++ b/src/lib/server/tmpl_tokenize.c
@@ -3106,7 +3106,7 @@ fr_slen_t tmpl_afrom_substr(TALLOC_CTX *ctx, tmpl_t **out,
 		 *	Deal with explicit casts...
 		 */
 		slen = tmpl_afrom_value_substr(ctx, out, in, quote, t_rules, true, p_rules);
-		if (slen > 0) return slen;
+		if (slen != 0) return slen;
 
 		/*
 		 *	See if it's a boolean value
@@ -3250,7 +3250,7 @@ fr_slen_t tmpl_afrom_substr(TALLOC_CTX *ctx, tmpl_t **out,
 		 *	as they cannot contain expansions.
 		 */
 		slen = tmpl_afrom_value_substr(ctx, out, in, quote, t_rules, false, p_rules);
-		if (slen > 0) return slen;
+		if (slen != 0) return slen;
 
 		vpt = tmpl_alloc_null(ctx);
 		slen = fr_sbuff_out_aunescape_until(vpt, &str, &our_in, SIZE_MAX,
@@ -3275,7 +3275,7 @@ fr_slen_t tmpl_afrom_substr(TALLOC_CTX *ctx, tmpl_t **out,
 		 */
 		if (xlat_is_literal(head)) {
 			slen = tmpl_afrom_value_substr(ctx, out, in, quote, t_rules, false, p_rules);
-			if (slen > 0) {
+			if (slen != 0) {
 				talloc_free(vpt);
 				return slen;
 			}