From: Selva Nair <selva.nair@gmail.com>
Date: Sat, 4 Jun 2016 04:57:43 +0000 (-0400)
Subject: Fix the comparison of pull options hash on restart
X-Git-Tag: v2.4_alpha1~79
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1899393543caa3cd5191c96176e8ecaa8e690eeb;p=thirdparty%2Fopenvpn.git

Fix the comparison of pull options hash on restart

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Steffan Karger <steffan.karger@fox-it.com>
Message-Id: <1465016263-23048-1-git-send-email-selva.nair@gmail.com>
URL: http://article.gmane.org/gmane.network.openvpn.devel/11783
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---

diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index 42baf97f0..4b044f475 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -1717,7 +1717,7 @@ options_hash_changed_or_zero(const struct md5_digest *a,
 {
   const struct md5_digest zero = {{0}};
   return memcmp (a, b, sizeof(struct md5_digest)) ||
-      memcmp (a, &zero, sizeof(struct md5_digest));
+      !memcmp (a, &zero, sizeof(struct md5_digest));
 }
 #endif /* P2MP */