From: Chris Lalancette <clalance@redhat.com>
Date: Wed, 28 Apr 2010 19:49:10 +0000 (-0400)
Subject: Fix a memory leak in the node_device_udev code
X-Git-Tag: v0.8.1~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=18b3096c402270634ebc89bd28a1248ad77b925b;p=thirdparty%2Flibvirt.git

Fix a memory leak in the node_device_udev code

We were over-writing a pointer without freeing it in
case of a disk device, leading to a memory leak.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
---

diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index 3a5a7e2e44..bcfe991fb7 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -815,13 +815,6 @@ static int udevProcessDisk(struct udev_device *device,
     union _virNodeDevCapData *data = &def->caps->data;
     int ret = 0;
 
-    data->storage.drive_type = strdup("disk");
-    if (data->storage.drive_type == NULL) {
-        virReportOOMError();
-        ret = -1;
-        goto out;
-    }
-
     if (udevGetUint64SysfsAttr(device,
                                "size",
                                &data->storage.num_blocks) == PROPERTY_ERROR) {