From: Boris Egorov Date: Tue, 19 Jan 2016 05:37:57 +0000 (+0600) Subject: libblkid: (zfs) add cast to fix UB [cppcheck] X-Git-Tag: v2.28-rc1~190 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=18b76be61c11fd5f11fcb84aa6a946d3b03d7225;p=thirdparty%2Futil-linux.git libblkid: (zfs) add cast to fix UB [cppcheck] [libblkid/src/superblocks/zfs.c:173]: (error) Shifting 32-bit value by 56 bits is undefined behaviour [libblkid/src/superblocks/zfs.c:173]: (error) Shifting 32-bit value by 40 bits is undefined behaviour --- diff --git a/libblkid/src/superblocks/zfs.c b/libblkid/src/superblocks/zfs.c index 371fd61da5..2804b151d9 100644 --- a/libblkid/src/superblocks/zfs.c +++ b/libblkid/src/superblocks/zfs.c @@ -170,7 +170,7 @@ static void zfs_extract_guid_name(blkid_probe pr, loff_t offset) static int find_uberblocks(const void *label, loff_t *ub_offset, int *swap_endian) { - uint64_t swab_magic = swab64(UBERBLOCK_MAGIC); + uint64_t swab_magic = swab64((uint64_t)UBERBLOCK_MAGIC); struct zfs_uberblock *ub; int i, found = 0; loff_t offset = VDEV_LABEL_UBERBLOCK;