From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 10 Apr 2018 15:05:20 +0000 (+0200)
Subject: conf: Disk 'shared' state is not guest ABI
X-Git-Tag: v4.3.0-rc1~170
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=18ba54c01543c108ed74f498cb21b363324f966c;p=thirdparty%2Flibvirt.git

conf: Disk 'shared' state is not guest ABI

Drop the checking of 'shared' from the ABI stability check. This
property controls whether the hypervisor allows concurrent access to the
same file, but this fact does not influence guest ABI.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 071ebaa4e1..35666c1347 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -20820,8 +20820,7 @@ virDomainDiskDefCheckABIStability(virDomainDiskDefPtr src,
 
     }
 
-    if (src->src->readonly != dst->src->readonly ||
-        src->src->shared != dst->src->shared) {
+    if (src->src->readonly != dst->src->readonly) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("Target disk access mode does not match source"));
         return false;