From: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Date: Thu, 28 Mar 2019 22:04:13 +0000 (+0100)
Subject: gnutls_memset(): calling explicit_bzero() is enough to zero-fill a buffer
X-Git-Tag: gnutls_3_6_8~62
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=18c85a9aca99080403a4fc2583fbb4302c3979e6;p=thirdparty%2Fgnutls.git

gnutls_memset(): calling explicit_bzero() is enough to zero-fill a buffer

If we use explicit_bzero() to zero-fill a buffer in gnutls_memset() we
don't need to zero it again via a volatile trick later in this function.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---

diff --git a/lib/safe-memfuncs.c b/lib/safe-memfuncs.c
index a9db39d2a7..b957b432cd 100644
--- a/lib/safe-memfuncs.c
+++ b/lib/safe-memfuncs.c
@@ -39,6 +39,7 @@ void gnutls_memset(void *data, int c, size_t size)
 #ifdef HAVE_EXPLICIT_BZERO
 	if (c == 0) {
 		explicit_bzero(data, size);
+		return;
 	}
 #endif
 	volatile_zero = 0;