From: Michael Tremer Date: Tue, 31 Dec 2024 13:37:42 +0000 (+0000) Subject: linter: Fix RELRO check X-Git-Tag: 0.9.30~630 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1900dbe4bfff782a43379cf00e1a8ddbd87a507f;p=pakfire.git linter: Fix RELRO check Signed-off-by: Michael Tremer --- diff --git a/src/libpakfire/linter-file.c b/src/libpakfire/linter-file.c index bbf16ee82..b8af528ff 100644 --- a/src/libpakfire/linter-file.c +++ b/src/libpakfire/linter-file.c @@ -631,9 +631,9 @@ static int pakfire_linter_file_check_relro(struct pakfire_linter_file* lfile) { if (r) return r; - // We are not fully RELRO - if (!has_bind_now) - return pakfire_linter_file_error(lfile, "Is not fully RELRO"); + // We are fully RELRO + if (has_bind_now) + return 0; // Walk through all program headers for (unsigned int i = 0;; i++) { @@ -642,10 +642,7 @@ static int pakfire_linter_file_check_relro(struct pakfire_linter_file* lfile) { switch (phdr.p_type) { case PT_GNU_RELRO: - r = pakfire_linter_file_warning(lfile, "Is partially RELRO"); - if (r < 0) - return 0; - break; + return pakfire_linter_file_warning(lfile, "Is partially RELRO"); default: break; @@ -653,7 +650,7 @@ static int pakfire_linter_file_check_relro(struct pakfire_linter_file* lfile) { } // This file does not seem to have PT_GNU_RELRO set - return pakfire_linter_file_error(lfile, "Is not fully RELRO"); + return pakfire_linter_file_error(lfile, "Is not RELRO"); } /*