From: Philippe Antoine <pantoine@oisf.net>
Date: Mon, 5 Dec 2022 09:42:58 +0000 (+0100)
Subject: ftp: disables debug assertion
X-Git-Tag: suricata-7.0.0-rc1~273
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=190c945e67a65cbaaf5a0650dfaf107cbbd66afb;p=thirdparty%2Fsuricata.git

ftp: disables debug assertion

Ticket: #5443

Until we decide on the right way to fix this.
---

diff --git a/src/app-layer-ftp.c b/src/app-layer-ftp.c
index 8980b6ccc4..74f1716557 100644
--- a/src/app-layer-ftp.c
+++ b/src/app-layer-ftp.c
@@ -1148,7 +1148,8 @@ static AppLayerResult FTPDataParse(Flow *f, FtpDataState *ftpdata_state,
     } else {
         if (ftpdata_state->state == FTPDATA_STATE_FINISHED) {
             SCLogDebug("state is already finished");
-            DEBUG_VALIDATE_BUG_ON(input_len); // data after state finished is a bug.
+            // TODO put back the assert after deciding on the bug...
+            // DEBUG_VALIDATE_BUG_ON(input_len); // data after state finished is a bug.
             SCReturnStruct(APP_LAYER_OK);
         }
         if ((direction & ftpdata_state->direction) == 0) {