From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 4 Jun 2014 08:57:21 +0000 (+0200)
Subject: cfg.mk: Introduce rule for setlocale()
X-Git-Tag: v1.2.6-rc1~196
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1919e355477b6211cb32a194a4aa895f0a5e4b06;p=thirdparty%2Flibvirt.git

cfg.mk: Introduce rule for setlocale()

In the past we had some issues where setlocale() was called without
corresponding include of locale.h. While on some systems this may
work, on others the compilation failed. We should have a syntax-check
rule for that to prevent this from happening again.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/cfg.mk b/cfg.mk
index 9e8fceced8..675af21fca 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -929,6 +929,15 @@ sc_prohibit_mixed_case_abbreviations:
 	halt='Use PCI, USB, SCSI, not Pci, Usb, Scsi'	\
 	  $(_sc_search_regexp)
 
+# Require #include <locale.h> in all files that call setlocale()
+sc_require_locale_h:
+	@for i in $$($(VC_LIST_EXCEPT) | grep '\.[chx]$$'); do			\
+		if ! grep -q setlocale\( $$i ; then continue; fi ;		\
+		if ! grep -q '# *include <locale.h>' $$i ; then			\
+			echo '$(ME): missing locale.h include in' $$i 1>&2; exit 1;	\
+		fi;															\
+	done;
+
 # We don't use this feature of maint.mk.
 prev_version_file = /dev/null