From: Ian Lance Taylor Date: Fri, 14 Aug 2020 22:27:15 +0000 (-0700) Subject: compiler: export thunks referenced by inline functions X-Git-Tag: releases/gcc-10.3.0~1029 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1925bff7f21e5aaffb9a7fcf1356e67472d64b03;p=thirdparty%2Fgcc.git compiler: export thunks referenced by inline functions The test case is https://golang.org/cl/248637. Fixes golang/go#40252 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/248638 --- diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 64b13f410e08..e425f15285ea 100644 --- a/gcc/go/gofrontend/MERGE +++ b/gcc/go/gofrontend/MERGE @@ -1,4 +1,4 @@ -2ad0970e9da95024110cd3244e9e21313af70a5f +823c91088bc6ac606362fc34b2880ce0de1624ad The first line of this file holds the git revision number of the last merge done from the gofrontend repository. diff --git a/gcc/go/gofrontend/expressions.cc b/gcc/go/gofrontend/expressions.cc index deac87448f33..8f59b18d47f6 100644 --- a/gcc/go/gofrontend/expressions.cc +++ b/gcc/go/gofrontend/expressions.cc @@ -1621,16 +1621,15 @@ Func_descriptor_expression::do_get_backend(Translate_context* context) || no->name().find("equal") != std::string::npos)) is_exported_runtime = true; - bool is_referenced_by_inline = - no->is_function() && no->func_value()->is_referenced_by_inline(); - bool is_hidden = ((no->is_function() && no->func_value()->enclosing() != NULL) || (Gogo::is_hidden_name(no->name()) - && !is_exported_runtime - && !is_referenced_by_inline) + && !is_exported_runtime) || Gogo::is_thunk(no)); + if (no->is_function() && no->func_value()->is_referenced_by_inline()) + is_hidden = false; + bvar = context->backend()->immutable_struct(var_name, asm_name, is_hidden, false, btype, bloc); diff --git a/gcc/go/gofrontend/gogo.cc b/gcc/go/gofrontend/gogo.cc index 212ef45a29c2..9d3d95309b21 100644 --- a/gcc/go/gofrontend/gogo.cc +++ b/gcc/go/gofrontend/gogo.cc @@ -3342,7 +3342,8 @@ class Create_function_descriptors : public Traverse Gogo* gogo_; }; -// Create a descriptor for every top-level exported function. +// Create a descriptor for every top-level exported function and every +// function referenced by an inline function. int Create_function_descriptors::function(Named_object* no) @@ -3350,8 +3351,9 @@ Create_function_descriptors::function(Named_object* no) if (no->is_function() && no->func_value()->enclosing() == NULL && !no->func_value()->is_method() - && !Gogo::is_hidden_name(no->name()) - && !Gogo::is_thunk(no)) + && ((!Gogo::is_hidden_name(no->name()) + && !Gogo::is_thunk(no)) + || no->func_value()->is_referenced_by_inline())) no->func_value()->descriptor(this->gogo_, no); return TRAVERSE_CONTINUE;