From: Leif Madsen Date: Mon, 17 May 2010 14:37:35 +0000 (+0000) Subject: Recorded merge of revisions 263456 via svnmerge from X-Git-Tag: 11.0.0-beta1~3025 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=193d495a8ad7e84af539f33db2d44a1524e55667;p=thirdparty%2Fasterisk.git Recorded merge of revisions 263456 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r263456 | lmadsen | 2010-05-17 09:35:18 -0500 (Mon, 17 May 2010) | 11 lines Manager cookies are not compatible with RFC2109. The Version field in the cookies we're setting contain quotes around the version number which is not compatible with RFC2109 and breaks some implementations. (closes issue #17231) Reported by: ecarruda Patches: manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559) manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559) Tested by: ecarruda, russell ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@263457 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/main/manager.c b/main/manager.c index c96c41a046..664e8583ce 100644 --- a/main/manager.c +++ b/main/manager.c @@ -4994,7 +4994,7 @@ static int generic_http_callback(struct ast_tcptls_session_instance *ser, ast_str_append(&http_header, 0, "Content-type: text/%s\r\n" "Cache-Control: no-cache;\r\n" - "Set-Cookie: mansession_id=\"%08x\"; Version=\"1\"; Max-Age=%d" + "Set-Cookie: mansession_id=\"%08x\"; Version=1; Max-Age=%d" "Pragma: SuppressEvents\r\n", contenttype[format], session->managerid, httptimeout);