From: Greg Hudson <ghudson@mit.edu>
Date: Thu, 25 Feb 2016 16:27:40 +0000 (-0500)
Subject: Fix KDC memory leak on failed S4U2Proxy requests
X-Git-Tag: krb5-1.15-beta1~248
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=194641a8ad7aecc6bc1d4848742c14569f14b900;p=thirdparty%2Fkrb5.git

Fix KDC memory leak on failed S4U2Proxy requests

Make sure to release stkt_server in process_tgs_req() if we fail
before its disposition is determined.  Reported by Will Fiveash.

ticket: 8363
target_version: 1.14-next
target_version: 1.13-next
tags: pullup
---

diff --git a/src/kdc/do_tgs_req.c b/src/kdc/do_tgs_req.c
index a52c960478..547a414417 100644
--- a/src/kdc/do_tgs_req.c
+++ b/src/kdc/do_tgs_req.c
@@ -869,6 +869,7 @@ cleanup:
     if (state)
         kdc_free_rstate(state);
     krb5_db_free_principal(kdc_context, server);
+    krb5_db_free_principal(kdc_context, stkt_server);
     krb5_db_free_principal(kdc_context, header_server);
     krb5_db_free_principal(kdc_context, client);
     krb5_db_free_principal(kdc_context, local_tgt_storage);