From: Peter Krempa Date: Tue, 20 Sep 2022 09:16:27 +0000 (+0200) Subject: bhyve: Don't stack-allocate huge error buffers X-Git-Tag: v9.8.0-rc1~223 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=194c75f458c9ba1d59d042f3195e59c88c07bea0;p=thirdparty%2Flibvirt.git bhyve: Don't stack-allocate huge error buffers _POSIX2_LINE_MAX is 2048. Allocate the buffers on the heap instead. Signed-off-by: Peter Krempa Reviewed-by: Kristina Hanicova --- diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 80d5a8804f..c8e1a10afe 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -380,7 +380,7 @@ virBhyveGetDomainTotalCpuStats(virDomainObj *vm, { struct kinfo_proc *kp; kvm_t *kd; - char errbuf[_POSIX2_LINE_MAX]; + g_autofree char *errbuf = g_new0(char, _POSIX2_LINE_MAX); int nprocs; int ret = -1; @@ -481,7 +481,7 @@ virBhyveProcessReconnectAll(struct _bhyveConn *driver) { kvm_t *kd; struct bhyveProcessReconnectData data; - char errbuf[_POSIX2_LINE_MAX]; + g_autofree char *errbuf = g_new0(char, _POSIX2_LINE_MAX); if ((kd = kvm_openfiles(NULL, NULL, NULL, O_RDONLY, errbuf)) == NULL) { virReportError(VIR_ERR_SYSTEM_ERROR,