From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 14 Sep 2020 08:00:37 +0000 (+0100)
Subject: Add explanitory comment for alive_update query
X-Git-Tag: release_3_0_22~418
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1962a002e576a80daa85f9cdb3d4e113e572e129;p=thirdparty%2Ffreeradius-server.git

Add explanitory comment for alive_update query
---

diff --git a/raddb/mods-config/sql/ippool-dhcp/mssql/queries.conf b/raddb/mods-config/sql/ippool-dhcp/mssql/queries.conf
index 656704a093b..9b49309dd76 100644
--- a/raddb/mods-config/sql/ippool-dhcp/mssql/queries.conf
+++ b/raddb/mods-config/sql/ippool-dhcp/mssql/queries.conf
@@ -201,7 +201,9 @@ start_update = "\
 
 #
 #  This query extends an existing lease (or offer) when a DHCP REQUEST packet
-#  arrives
+#  arrives.  This query must update a row when a lease is succesfully requested
+#  - queries that update no rows will result in a NAK reply.  In this example
+#  incrementing "counter" is used to achieve this.
 #
 alive_update = "\
 	UPDATE ${ippool_table} \
diff --git a/raddb/mods-config/sql/ippool-dhcp/mysql/queries.conf b/raddb/mods-config/sql/ippool-dhcp/mysql/queries.conf
index 21c69d43959..2ac6b081ee4 100644
--- a/raddb/mods-config/sql/ippool-dhcp/mysql/queries.conf
+++ b/raddb/mods-config/sql/ippool-dhcp/mysql/queries.conf
@@ -165,7 +165,9 @@ start_update = "\
 
 #
 #  This query extends an existing lease (or offer) when a DHCP REQUEST packet
-#  arrives
+#  arrives.  This query must update a row when a lease is succesfully requested
+#  - queries that update no rows will result in a NAK reply.  In this example
+#  incrementing "counter" is used to achieve this.
 #
 alive_update = "\
 	UPDATE ${ippool_table} \
diff --git a/raddb/mods-config/sql/ippool-dhcp/oracle/queries.conf b/raddb/mods-config/sql/ippool-dhcp/oracle/queries.conf
index 92be269c0fc..5bbc79b47d4 100644
--- a/raddb/mods-config/sql/ippool-dhcp/oracle/queries.conf
+++ b/raddb/mods-config/sql/ippool-dhcp/oracle/queries.conf
@@ -139,7 +139,9 @@ start_commit = "COMMIT"
 
 #
 #  This query extends an existing lease (or offer) when a DHCP REQUEST packet
-#  arrives
+#  arrives.  This query must update a row when a lease is succesfully requested
+#  - queries that update no rows will result in a NAK reply.  In this example
+#  incrementing "counter" is used to achieve this.
 #
 alive_update = "\
 	UPDATE ${ippool_table} \
diff --git a/raddb/mods-config/sql/ippool-dhcp/postgresql/queries.conf b/raddb/mods-config/sql/ippool-dhcp/postgresql/queries.conf
index 8b13013685d..41bd4115cca 100644
--- a/raddb/mods-config/sql/ippool-dhcp/postgresql/queries.conf
+++ b/raddb/mods-config/sql/ippool-dhcp/postgresql/queries.conf
@@ -235,7 +235,9 @@ start_update = "\
 
 #
 #  This query extends an existing lease (or offer) when a DHCP REQUEST packet
-#  arrives
+#  arrives.  This query must update a row when a lease is succesfully requested
+#  - queries that update no rows will result in a NAK reply.  In this example
+#  incrementing "counter" is used to achieve this.
 #
 alive_update = "\
 	UPDATE ${ippool_table} \
diff --git a/raddb/mods-config/sql/ippool-dhcp/sqlite/queries.conf b/raddb/mods-config/sql/ippool-dhcp/sqlite/queries.conf
index 7f10438338a..ddda26c81a4 100644
--- a/raddb/mods-config/sql/ippool-dhcp/sqlite/queries.conf
+++ b/raddb/mods-config/sql/ippool-dhcp/sqlite/queries.conf
@@ -178,7 +178,9 @@ start_update = "\
 
 #
 #  This query extends an existing lease (or offer) when a DHCP REQUEST packet
-#  arrives
+#  arrives.  This query must update a row when a lease is succesfully requested
+#  - queries that update no rows will result in a NAK reply.  In this example
+#  incrementing "counter" is used to achieve this.
 #
 alive_update = "\
 	UPDATE ${ippool_table} \