From: Christos Tsantilas <chtsanti@users.sourceforge.net>
Date: Wed, 6 Jan 2016 14:32:07 +0000 (+1300)
Subject: Ssl::CertValidationHelper::sslSubmit: Assure that the callback->getDialer()
X-Git-Tag: SQUID_3_5_13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1988de5bff40bc85b8d0d95298fc4715c19f2d56;p=thirdparty%2Fsquid.git

Ssl::CertValidationHelper::sslSubmit: Assure that the callback->getDialer()

 ... return non NULL before use the result

Detected by Coverity Scan. Issue 1346998
---

diff --git a/src/ssl/helper.cc b/src/ssl/helper.cc
index 939c4d13b4..c378758ea4 100644
--- a/src/ssl/helper.cc
+++ b/src/ssl/helper.cc
@@ -264,6 +264,7 @@ void Ssl::CertValidationHelper::sslSubmit(Ssl::CertValidationRequest const &requ
         Ssl::CertValidationResponse::Pointer resp = new Ssl::CertValidationResponse;
         resp->resultCode = ::Helper::BrokenHelper;
         Ssl::CertValidationHelper::CbDialer *dialer = dynamic_cast<Ssl::CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = resp;
         ScheduleCallHere(callback);
         return;
@@ -287,6 +288,7 @@ void Ssl::CertValidationHelper::sslSubmit(Ssl::CertValidationRequest const &requ
             (validationResponse = CertValidationHelper::HelperCache->get(crtdvdData->query.c_str()))) {
 
         CertValidationHelper::CbDialer *dialer = dynamic_cast<CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = *validationResponse;
         ScheduleCallHere(callback);
         SSL_free(crtdvdData->ssl);