From: guy.pyrzak%gmail.com <> Date: Tue, 20 May 2008 21:39:04 +0000 (+0000) Subject: Bug 433987 - show_bug.cgi javascript error on changing status X-Git-Tag: bugzilla-3.3~3 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=199feb47eee0d0bba43df3f012415ad24796a648;p=thirdparty%2Fbugzilla.git Bug 433987 - show_bug.cgi javascript error on changing status Patch By Guy Pyrzak r=mkanat a=mkanat --- diff --git a/js/field.js b/js/field.js index 044c9b6ac3..15b5d4f794 100644 --- a/js/field.js +++ b/js/field.js @@ -261,7 +261,7 @@ function showHideStatusItems(e, dupArrayInfo) { YAHOO.util.Dom.setStyle('resolution_settings', 'display', 'inline'); YAHOO.util.Dom.setStyle('resolution_settings_warning', 'display', 'block'); } - else if (close_status_array.indexOf(el.value) > -1) { + else if ( bz_isValueInArray(close_status_array, el.value) ) { // hide duplicate and show resolution YAHOO.util.Dom.setStyle('resolution_settings', 'display', 'inline'); YAHOO.util.Dom.setStyle('resolution_settings_warning', 'display', 'block'); @@ -273,7 +273,7 @@ function showDuplicateItem(e) { var resolution = document.getElementById('resolution'); var bug_status = document.getElementById('bug_status'); if (resolution) { - if (resolution.value == 'DUPLICATE' && close_status_array.indexOf(bug_status.value) > -1 ) { + if (resolution.value == 'DUPLICATE' && bz_isValueInArray( close_status_array, bug_status.value) ) { // hide resolution show duplicate YAHOO.util.Dom.setStyle('duplicate_settings', 'display', 'inline'); YAHOO.util.Dom.setStyle('dup_id_discoverable', 'display', 'none');