From: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Mon, 3 Oct 2011 05:24:44 +0000 (+0000)
Subject: Fix file descriptor leak on error in read_igmp()
X-Git-Tag: v3.0.0~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=19bcc05beade576878abc04c53f17d4a5a620610;p=thirdparty%2Fiproute2.git

Fix file descriptor leak on error in read_igmp()

Detected by cppcheck.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---

diff --git a/ip/ipmaddr.c b/ip/ipmaddr.c
index 5a52c856f..3ae947800 100644
--- a/ip/ipmaddr.c
+++ b/ip/ipmaddr.c
@@ -128,8 +128,10 @@ void read_igmp(struct ma_info **result_p)
 	if (!fp)
 		return;
 	memset(&m, 0, sizeof(m));
-	if (!fgets(buf, sizeof(buf), fp))
+	if (!fgets(buf, sizeof(buf), fp)) {
+		fclose(fp);
 		return;
+	}
 
 	m.addr.family = AF_INET;
 	m.addr.bitlen = 32;