From: Florian Weimer Date: Tue, 5 Jul 2022 07:05:22 +0000 (+0200) Subject: locale: Fix signed char bug in lr_getc X-Git-Tag: glibc-2.36~91 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=19d494445981a09503e4a0175732745c39dd7c21;p=thirdparty%2Fglibc.git locale: Fix signed char bug in lr_getc The array lr->buf contains characters, which can be signed. A 0xff byte in the input could be incorrectly reported as EOF. More importantly, get_string in linereader.c converts a signed input byte to a Unicode code point using ADDWC ((uint32_t) ch), under the assumption that this decodes the ISO-8859-1 input encoding. If char is signed, this does not give the correct result. This means that ISO-8859-1 input files for localedef are not actually supported, contrary to the comment in get_string. This is a happy accident because we can therefore change the file encoding to UTF-8 without impacting backwards compatibility. While at it, remove the \32 check for MS-DOS end-of-file character (^Z). Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell --- diff --git a/locale/programs/linereader.h b/locale/programs/linereader.h index 0fb10ec8332..653a71d2d16 100644 --- a/locale/programs/linereader.h +++ b/locale/programs/linereader.h @@ -134,7 +134,7 @@ lr_getc (struct linereader *lr) return EOF; } - return lr->buf[lr->idx] == '\32' ? EOF : lr->buf[lr->idx++]; + return lr->buf[lr->idx++] & 0xff; }