From: Amos Jeffries <squid3@treenet.co.nz>
Date: Wed, 25 Dec 2013 21:35:15 +0000 (-0700)
Subject: Fix \-unescaping in quoted strings from helpers
X-Git-Tag: SQUID_3_4_2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=19d7cbba2d95b86b0f60e213f2c196740581bdde;p=thirdparty%2Fsquid.git

Fix \-unescaping in quoted strings from helpers

strwordtok() was unescaping '\' values in unquoted tokens. This causes
problems with NTLM helper response user\DOMAIN values which are sent as
a un-quoted un-escaped value.

Restrict un-escaping of '\' to only occur when inside "quoted" words.
---

diff --git a/src/String.cc b/src/String.cc
index e5ff7a2f5d..f0010cf1bd 100644
--- a/src/String.cc
+++ b/src/String.cc
@@ -376,7 +376,8 @@ strwordtok(char *buf, char **t)
         switch (ch) {
 
         case '\\':
-            ++p;
+            if (quoted)
+                ++p;
 
             switch (*p) {