From: Josh Conner <jconner@apple.com>
Date: Mon, 8 Aug 2005 18:41:04 +0000 (+0000)
Subject: re PR rtl-optimization/23241 (Invalid code generated for comparison of uchar to 255)
X-Git-Tag: releases/gcc-3.4.5~265
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=19f5fbb8c40332c89613fbaa8542d39bd8848d88;p=thirdparty%2Fgcc.git

re PR rtl-optimization/23241 (Invalid code generated for comparison of uchar to 255)

	PR rtl-optimization/23241
	* combine.c (simplify_comparison): Fix error in determining
	whether to lift a subreg from comparison.

From-SVN: r102873
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 52cfb1fa1ebd..ef76da76c474 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2005-08-08  Josh Conner  <jconner@apple.com>
+
+	PR rtl-optimization/23241
+	* combine.c (simplify_comparison): Fix error in determining
+	whether to lift a subreg from comparison.
+
 2005-08-08  Richard Sandiford  <richard@codesourcery.com>
 
 	PR middle-end/21964
diff --git a/gcc/combine.c b/gcc/combine.c
index 0a3f3816f999..8f43c23eb189 100644
--- a/gcc/combine.c
+++ b/gcc/combine.c
@@ -10739,7 +10739,7 @@ simplify_comparison (enum rtx_code code, rtx *pop0, rtx *pop1)
 		      /* (A - C1) always sign-extends, like C2.  */
 		      && num_sign_bit_copies (a, inner_mode)
 			 > (unsigned int) (GET_MODE_BITSIZE (inner_mode)
-					   - mode_width - 1)))
+					   - (mode_width - 1))))
 		{
 		  op0 = SUBREG_REG (op0);
 		  continue;