From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 9 Feb 2023 02:53:26 +0000 (-0600)
Subject: Don't assert if no virtual servers are configured
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1a055f1f95c2dad80ab33f6eeaa0a10e598f32b3;p=thirdparty%2Ffreeradius-server.git

Don't assert if no virtual servers are configured

Print a nice error message instead
---

diff --git a/src/lib/server/virtual_servers.c b/src/lib/server/virtual_servers.c
index 5ae9ee979d6..bda76a1b951 100644
--- a/src/lib/server/virtual_servers.c
+++ b/src/lib/server/virtual_servers.c
@@ -1162,9 +1162,17 @@ int virtual_servers_thread_instantiate(TALLOC_CTX *ctx, fr_event_list_t *el)
  */
 int virtual_servers_instantiate(void)
 {
-	size_t	i, server_cnt = virtual_servers ? talloc_array_length(virtual_servers) : 0;
+	size_t	i, server_cnt;
 
-	fr_assert(virtual_servers);
+	/*
+	 *	User didn't specify any "server" sections
+	 */
+	if (unlikely(!virtual_servers)) {
+		ERROR("No virtual servers configured");
+		return -1;
+	}
+
+	server_cnt = talloc_array_length(virtual_servers);
 
 	DEBUG2("#### Instantiating listeners ####");