From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Tue, 28 Sep 2021 23:07:40 +0000 (+1300)
Subject: tests/krb5: Don't include empty AD-IF-RELEVANT
X-Git-Tag: ldb-2.5.0~415
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1a08399cd8169a525cc9e7aed99da84ef20e5b9c;p=thirdparty%2Fsamba.git

tests/krb5: Don't include empty AD-IF-RELEVANT

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14642

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/krb5/raw_testcase.py b/python/samba/tests/krb5/raw_testcase.py
index 2e289c90ce7..e008223eb23 100644
--- a/python/samba/tests/krb5/raw_testcase.py
+++ b/python/samba/tests/krb5/raw_testcase.py
@@ -3424,14 +3424,19 @@ class RawKerberosTest(TestCaseInTempDir):
                 if expect_pac:
                     self.assertIsNotNone(old_pac, 'Expected PAC')
 
-                ad_relevant = self.der_encode(
-                    relevant_elems,
-                    asn1Spec=krb5_asn1.AD_IF_RELEVANT())
-
-                authdata_elem = self.AuthorizationData_create(AD_IF_RELEVANT,
-                                                              ad_relevant)
+                if relevant_elems:
+                    ad_relevant = self.der_encode(
+                        relevant_elems,
+                        asn1Spec=krb5_asn1.AD_IF_RELEVANT())
+
+                    authdata_elem = self.AuthorizationData_create(
+                        AD_IF_RELEVANT,
+                        ad_relevant)
+                else:
+                    authdata_elem = None
 
-            new_auth_data.append(authdata_elem)
+            if authdata_elem is not None:
+                new_auth_data.append(authdata_elem)
 
         if expect_pac:
             self.assertIsNotNone(ad_relevant, 'Expected AD-RELEVANT')