From: Hugo Landau <hlandau@openssl.org>
Date: Tue, 2 May 2023 17:21:07 +0000 (+0100)
Subject: QUIC TSERVER: Use a random port in the tserver test
X-Git-Tag: openssl-3.2.0-alpha1~779
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1a0de4c1eea1f32a3e1113add26625d49b3854d8;p=thirdparty%2Fopenssl.git

QUIC TSERVER: Use a random port in the tserver test

Fixes nondeterministic failures where BIO_bind would fail on some
platforms.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20856)
---

diff --git a/test/quic_tserver_test.c b/test/quic_tserver_test.c
index e9ae4703b20..cc412eafd0f 100644
--- a/test/quic_tserver_test.c
+++ b/test/quic_tserver_test.c
@@ -64,7 +64,6 @@ static int do_test(int use_thread_assist, int use_fake_time, int use_inject)
     union BIO_sock_info_u s_info = {0};
     SSL_CTX *c_ctx = NULL;
     SSL *c_ssl = NULL;
-    short port = 8186;
     int c_connected = 0, c_write_done = 0, c_begin_read = 0, s_read_done = 0;
     int c_wait_eos = 0, c_done_eos = 0;
     int c_start_idle_test = 0, c_done_idle_test = 0;
@@ -89,8 +88,7 @@ static int do_test(int use_thread_assist, int use_fake_time, int use_inject)
     if (!TEST_ptr(s_addr_ = BIO_ADDR_new()))
         goto err;
 
-    if (!TEST_true(BIO_ADDR_rawmake(s_addr_, AF_INET, &ina, sizeof(ina),
-                                    htons(port))))
+    if (!TEST_true(BIO_ADDR_rawmake(s_addr_, AF_INET, &ina, sizeof(ina), 0)))
         goto err;
 
     if (!TEST_true(BIO_bind(s_fd, s_addr_, 0)))