From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Tue, 21 Nov 2023 10:25:10 +0000 (+0100)
Subject: sources: drop unreachable log message
X-Git-Tag: 4.5-pre1~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1a15be1e9e0f541057d55f3d4ab09fb69cadd6be;p=thirdparty%2Fchrony.git

sources: drop unreachable log message

With forced reselection during source removal selected_source_index
can only be INVALID_SOURCE if there are no sources. The "Can't
synchronise: no sources" message couldn't be logged even before that as
SRC_ReselectSource() resets the index before calling SRC_SelectSource().

Replace the message with an assertion.
---

diff --git a/sources.c b/sources.c
index 4bfc1a1c..8f6caa0a 100644
--- a/sources.c
+++ b/sources.c
@@ -854,11 +854,9 @@ SRC_SelectSource(SRC_Instance updated_inst)
   }
 
   if (n_sources == 0) {
-    /* In this case, we clearly cannot synchronise to anything */
-    if (selected_source_index != INVALID_SOURCE) {
-      log_selection_message(LOGS_INFO, "Can't synchronise: no sources", NULL);
-      selected_source_index = INVALID_SOURCE;
-    }
+    /* Removed sources are unselected before actual removal */
+    if (selected_source_index != INVALID_SOURCE)
+      assert(0);
     return;
   }