From: Michael J. Ryan Date: Mon, 14 Mar 2016 20:18:08 +0000 (-0700) Subject: Update tooltip.js X-Git-Tag: v4.0.0-alpha.6~304^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1a23279237b5360dab15d91aac85cbf8306e560a;p=thirdparty%2Fbootstrap.git Update tooltip.js Don't reference `Tether` via attachment to `window`, with the update one can import bootstrap providing the dependencies in webpack with: ``` new webpack.ProvidePlugin({ $: 'jquery', jQuery: 'jquery', Tether: 'tether', }); ``` Then inside one's own bootstrap/globals, `import 'bootstrap';` will simply work, and $/jQuery can be used from there. I had wanted to do this, but also expose jQuery, Tether, etc when in development build in my code, but if I provide `window.Tether`, I can't then expose it to the outside... --- diff --git a/js/src/tooltip.js b/js/src/tooltip.js index 77803dc402..03d9e4cc8e 100644 --- a/js/src/tooltip.js +++ b/js/src/tooltip.js @@ -16,7 +16,7 @@ const Tooltip = (($) => { * Check for Tether dependency * Tether - http://github.hubspot.com/tether/ */ - if (window.Tether === undefined) { + if ('undefined' === typeof Tether) { throw new Error('Bootstrap tooltips require Tether (http://github.hubspot.com/tether/)') }