From: Colin Vidal <colin@isc.org>
Date: Tue, 25 Nov 2025 14:34:26 +0000 (+0100)
Subject: check remote-servers list correctness
X-Git-Tag: v9.21.16~18^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1a732b6b8ecc89232724d80adba84350976ae2ca;p=thirdparty%2Fbind9.git

check remote-servers list correctness

`check.c` only checks if `remote-servers`, `primaries`, etc. are not
duplicated inside the configuration file, but does not check the
correctness of its definition. This commit fixes this by calling
`validate_remotes()` for each `remote-servers` (and other aliases),
which validates the correctness of the definition itself (this is the
same call done to validate other cases like `also-notify`, etc.).
---

diff --git a/lib/isccfg/check.c b/lib/isccfg/check.c
index 022e29d0dad..6ff5b12a0bd 100644
--- a/lib/isccfg/check.c
+++ b/lib/isccfg/check.c
@@ -84,6 +84,9 @@ keydirexist(const cfg_obj_t *zcgf, const char *optname, dns_name_t *zname,
 static const cfg_obj_t *
 find_maplist(const cfg_obj_t *config, const char *listname, const char *name);
 
+static isc_result_t
+validate_remotes(const cfg_obj_t *obj, const cfg_obj_t *config,
+		 uint32_t *countp, isc_mem_t *mctx);
 static void
 freekey(char *key, unsigned int type, isc_symvalue_t value, void *userarg) {
 	UNUSED(type);
@@ -2084,6 +2087,12 @@ check_remoteserverlist(const cfg_obj_t *cctx, const char *list,
 			result = tresult;
 			break;
 		}
+
+		uint32_t dummy = 0;
+		result = validate_remotes(obj, cctx, &dummy, mctx);
+		if (result != ISC_R_SUCCESS) {
+			break;
+		}
 	}
 	return result;
 }