From: Mark Andrews <marka@isc.org>
Date: Thu, 30 Jan 2020 08:41:32 +0000 (+1100)
Subject: isc_mem_get cannot fail
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1a8b581510e5784a36f265c72dd8022c6a7cb562;p=thirdparty%2Fbind9.git

isc_mem_get cannot fail
---

diff --git a/lib/dns/client.c b/lib/dns/client.c
index 54e14ce1110..263ad00b975 100644
--- a/lib/dns/client.c
+++ b/lib/dns/client.c
@@ -1340,13 +1340,7 @@ dns_client_startresolve(dns_client_t *client, const dns_name_t *name,
 	ISC_LIST_INIT(event->answerlist);
 
 	rctx = isc_mem_get(mctx, sizeof(*rctx));
-	if (rctx == NULL)
-		result = ISC_R_NOMEMORY;
-	else {
-		isc_mutex_init(&rctx->lock);
-	}
-	if (result != ISC_R_SUCCESS)
-		goto cleanup;
+	isc_mutex_init(&rctx->lock);
 
 	result = getrdataset(mctx, &rdataset);
 	if (result != ISC_R_SUCCESS)