From: Stefan Metzmacher <metze@samba.org>
Date: Fri, 28 Aug 2020 13:56:35 +0000 (+0200)
Subject: s3:share_mode_lock: add missing 'goto done' in share_mode_cleanup_disconnected()
X-Git-Tag: talloc-2.3.2~677
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1aa1ac97082f81f6dc62f345823d2dd345e0afd7;p=thirdparty%2Fsamba.git

s3:share_mode_lock: add missing 'goto done' in share_mode_cleanup_disconnected()

When cleanup_disconnected_lease() fails we should stop,
at least we do that if brl_cleanup_disconnected() fails.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14428

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/source3/locking/share_mode_lock.c b/source3/locking/share_mode_lock.c
index a1a7b9793cf..965c5ab1883 100644
--- a/source3/locking/share_mode_lock.c
+++ b/source3/locking/share_mode_lock.c
@@ -1694,6 +1694,7 @@ bool share_mode_cleanup_disconnected(struct file_id fid,
 			  (data->stream_name == NULL)
 			  ? "" : data->stream_name,
 			  open_persistent_id);
+		goto done;
 	}
 
 	ok = brl_cleanup_disconnected(fid, open_persistent_id);