From: Simon McVittie Date: Thu, 3 Mar 2011 16:55:55 +0000 (+0000) Subject: _dbus_marshal_write_fixed_multi: remove obsolete FIXME comment X-Git-Tag: dbus-1.4.8~9^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1aa5aaa9e297eaed231cf0270d097fe4284dc274;p=thirdparty%2Fdbus.git _dbus_marshal_write_fixed_multi: remove obsolete FIXME comment As far as I can tell, we've never accepted out-of-range booleans and canonicalized them, ever since this was first committed in 2004. If sent, they'd be considered to be invalid by recipients, so they're unambiguously an error. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35182 Reviewed-by: Will Thompson --- diff --git a/dbus/dbus-marshal-basic.c b/dbus/dbus-marshal-basic.c index ea18dbf31..3cbc72169 100644 --- a/dbus/dbus-marshal-basic.c +++ b/dbus/dbus-marshal-basic.c @@ -1065,8 +1065,6 @@ _dbus_marshal_write_fixed_multi (DBusString *str, case DBUS_TYPE_INT16: case DBUS_TYPE_UINT16: return marshal_fixed_multi (str, insert_at, vp, n_elements, byte_order, 2, pos_after); - /* FIXME: we canonicalize to 0 or 1 for the single boolean case - * should we here too ? */ case DBUS_TYPE_BOOLEAN: case DBUS_TYPE_INT32: case DBUS_TYPE_UINT32: