From: Petr Viktorin <encukou@gmail.com>
Date: Fri, 6 Jun 2025 14:08:58 +0000 (+0200)
Subject: gh-134160: Use PyModuleDef.m_free in the example module xxlimited (GH-135174)
X-Git-Tag: v3.15.0a1~1369
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1adca08d658ee2d520f3193960eaf3ae2ead1cef;p=thirdparty%2FPython%2Fcpython.git

gh-134160: Use PyModuleDef.m_free in the example module xxlimited (GH-135174)

Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
---

diff --git a/Modules/xxlimited.c b/Modules/xxlimited.c
index 26ac35734fb0..0480fb084987 100644
--- a/Modules/xxlimited.c
+++ b/Modules/xxlimited.c
@@ -424,6 +424,13 @@ xx_clear(PyObject *module)
     return 0;
 }
 
+static void
+xx_free(void *module)
+{
+    // allow xx_modexec to omit calling xx_clear on error
+    (void)xx_clear((PyObject *)module);
+}
+
 static struct PyModuleDef xxmodule = {
     PyModuleDef_HEAD_INIT,
     .m_name = "xxlimited",
@@ -433,9 +440,7 @@ static struct PyModuleDef xxmodule = {
     .m_slots = xx_slots,
     .m_traverse = xx_traverse,
     .m_clear = xx_clear,
-    /* m_free is not necessary here: xx_clear clears all references,
-     * and the module state is deallocated along with the module.
-     */
+    .m_free = xx_free,
 };