From: Sumit Kumar (sumikum7) <sumikum7@cisco.com>
Date: Wed, 5 Mar 2025 13:14:09 +0000 (+0000)
Subject: Pull request #4646: config_parser : fixing unchecked return in snort_config
X-Git-Tag: 3.7.1.0~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b3cddd01d8a6b07accccbd283612047747573e8;p=thirdparty%2Fsnort3.git

Pull request #4646: config_parser : fixing unchecked return in snort_config

Merge in SNORT/snort3 from ~SUMIKUM7/snort3:coverity_CSCwo20129 to master

Squashed commit of the following:

commit 14a2c51a860fde5116dcd22d153b94acbad38c2c
Author: Sumit Kumar <sumikum7@cisco.com>
Date:   Wed Mar 5 11:48:26 2025 +0530

    config_parser : fixing the no return check warning rather than supressing it

commit 55404aa73c8ef2cbd06c1d39044816222b644066
Author: Sumit Kumar <sumikum7@cisco.com>
Date:   Tue Mar 4 19:58:50 2025 +0530

    config_parser : turning down false positive warnings

commit 9b72c801eedcf5109044ff620b314fb04ab9e481
Author: Sumit Kumar <sumikum7@cisco.com>
Date:   Tue Mar 4 11:23:56 2025 +0530

    config_parser : turning down false positive warnings
---

diff --git a/src/main/snort_config.cc b/src/main/snort_config.cc
index 05de97829..f603f3faf 100644
--- a/src/main/snort_config.cc
+++ b/src/main/snort_config.cc
@@ -726,8 +726,7 @@ void SnortConfig::set_obfuscation_mask(const char* mask)
         return;
 
     output_flags |= OUTPUT_FLAG__OBFUSCATE;
-
-    obfuscation_net.set(mask);
+    static_cast<void>(obfuscation_net.set(mask));
 }
 
 void SnortConfig::set_gid(const char* args)