From: James Jones <jejones3141@gmail.com>
Date: Tue, 11 Jul 2023 20:42:13 +0000 (-0500)
Subject: Check for error return from fr_sbuff_in_bstrncpy() (CID #1503901)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b480276ebe77abcdc0741b3f89c9ad13d9a95e0;p=thirdparty%2Ffreeradius-server.git

Check for error return from fr_sbuff_in_bstrncpy() (CID #1503901)
---

diff --git a/src/modules/rlm_smtp/rlm_smtp.c b/src/modules/rlm_smtp/rlm_smtp.c
index c267bba869a..93b45fda99d 100644
--- a/src/modules/rlm_smtp/rlm_smtp.c
+++ b/src/modules/rlm_smtp/rlm_smtp.c
@@ -410,8 +410,10 @@ static int str_to_attachments(fr_mail_ctx_t *uctx, curl_mime *mime, char const *
 	}
 
 	/* Copy the filename into the buffer */
-	/* coverity[check_return] */
-	fr_sbuff_in_bstrncpy(path_buffer, str, len);
+	if (fr_sbuff_in_bstrncpy(path_buffer, str, len) < 0) {
+		RDEBUG2("Cannot copy filename");
+		return 0;
+	}
 
 	/* Add the file attachment as a mime encoded part */
 	part = curl_mime_addpart(mime);