From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Sun, 5 Feb 2023 19:52:11 +0000 (+0200)
Subject: lib-imap-client: Fix crash if SSL initialization fails when connecting
X-Git-Tag: 2.4.0~2964
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1b52e3d1aec06f22bc181bb75e92caf9cc3f166a;p=thirdparty%2Fdovecot%2Fcore.git

lib-imap-client: Fix crash if SSL initialization fails when connecting

This could be for example due to invalid SSL certificate settings.
---

diff --git a/src/lib-imap-client/imapc-connection.c b/src/lib-imap-client/imapc-connection.c
index fe5bc63234..a8c9b366b6 100644
--- a/src/lib-imap-client/imapc-connection.c
+++ b/src/lib-imap-client/imapc-connection.c
@@ -1727,8 +1727,10 @@ static int imapc_connection_connected(struct imapc_connection *conn)
 				    conn);
 
 	if (conn->client->set.ssl_mode == IMAPC_CLIENT_SSL_MODE_IMMEDIATE) {
-		if (imapc_connection_ssl_init(conn) < 0)
+		if (imapc_connection_ssl_init(conn) < 0) {
 			imapc_connection_disconnect(conn);
+			return -1;
+		}
 	}
 	return imapc_connection_output(conn);
 }